Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Fix pep561_integration_test.py to be hermetic to new Pants releases (Cherry-pick of #12961) #12963

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

Eric-Arellano
Copy link
Contributor

pantsbuild.pants.testutil depends on pantsbuild.pants. Our test for testutil wasn't including the wheel for pantsbuild.pants from the filesystem, so it was falling back to PyPI to satisfy that dep. That works when the wheel is released to PyPI, but caused our new release of Pants 2.7.0rc3 to fail as the wheel is not yet published.

[ci skip-rust]
[ci skip-build-wheels]

… releases (Cherry-pick of pantsbuild#12961)

`pantsbuild.pants.testutil` depends on `pantsbuild.pants`. Our test for testutil wasn't including the wheel for pantsbuild.pants from the filesystem, so it was falling back to PyPI to satisfy that dep. That works when the wheel is released to PyPI, but caused our new release of Pants 2.7.0rc3 to fail as the wheel is not yet published.

[ci skip-rust]
[ci skip-build-wheels]
@stuhood stuhood merged commit 80ce932 into pantsbuild:2.7.x Sep 21, 2021
@Eric-Arellano Eric-Arellano deleted the cp-pep561 branch September 21, 2021 04:13
@stuhood stuhood mentioned this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants