Handle a quirk when building on MacOS Big Sur. #12857
Conversation
[ci skip-rust] [ci skip-build-wheels]
| register( | ||
| "--macos-big-sur-compatibility", | ||
| type=bool, | ||
| default=False, |
There was a problem hiding this comment.
Should we configure this as True in our pants.toml or in some more specific way such that releases do the right thing?
There was a problem hiding this comment.
Oh, oops, yes we should. It seems like this should usually be True, but I'm not confident enough in that fact for that to be the default.
[ci skip-rust] [ci skip-build-wheels]
|
Is there a pip issue we could reference? (unless I missed it, on the phone). Feels like this should be resolved in pip eventually. |
|
There are some discussions around Big Sur compatibility, but I haven't found a ticket. I'd file one except I'm not sure I fully understand the issue. I think it may only be happening in some cases, because there are "11_0" wheels out there that presumably people are successfully consuming. |
|
FWIW, I had to set this to False to build on my Mac today... as my python was configured with "11.6", it bailed hard when we overrode it with "10.16". |
|
Yeah, very unclear to me what the right thing to do is. But good that it's False by default at least. |
Adds an option to set the Big Sur platform to "10.16" instead of the new scheme of "11.0",
when building dists. This may be required for pip to be able to install the resulting dists.
Also ensures that this will work for our own wheels, by setting this when building the native code
(otherwise setup.py will warn that the native code platform is incompatible, and ignore the 10.16 setting).
[ci skip-rust]
[ci skip-build-wheels]