Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] use tower::retry::Retry for retries #12614

Closed
wants to merge 1 commit into from
Closed

[WIP] use tower::retry::Retry for retries #12614

wants to merge 1 commit into from

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Aug 20, 2021

Use tower::retry::Retry for retries instead of retry_call.

WIP: The types for tower::retry::Retry are complex and I'm going to need to get some advice.

[ci skip-build-wheels]

checkpoint
3a829ec 
[ci skip-build-wheels]
@tdyas tdyas changed the title [WIP} use tower::retry::Retry for retries [WIP] use tower::retry::Retry for retries Aug 20, 2021
@tdyas
Copy link
Contributor Author

tdyas commented Aug 20, 2021

Doesn't compile. I tried 'static lifetime for the future inside tower::retry::Policy but that failed to compile, and now have tried to be generic on lifetime (via 'a) but that also fails to compile.

@tdyas tdyas mentioned this pull request Aug 20, 2021
Closed
@tdyas
Copy link
Contributor Author

tdyas commented Aug 20, 2021

Apparently tonic does not work with tower::retry::Retry: hyperium/tonic#733

@tdyas tdyas closed this Aug 20, 2021
@tdyas tdyas deleted the retry_via_tower branch February 20, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tdyas