Remove the option inheritance and recursive options features. #12519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
force-pushed
the
options_inheritance2
branch
from
c324dc5 to
41309bb
Compare
[ci skip-rust] [ci skip-build-wheels]
benjyw
force-pushed
the
options_inheritance2
branch
from
41309bb to
cea5a1f
Compare
|
A follow-up change may clean up, simplify or even remove ParserHierarchy, but this PR is big enough already. |
benjyw
commented
Aug 7, 2021
| scope: str, | ||
| inherit_from_enclosing_scope: bool = True, | ||
| ) -> OptionValueContainer: | ||
| def for_scope(self, scope: str, check_deprecations: bool = True) -> OptionValueContainer: |
There was a problem hiding this comment.
Previously we piggybacked off inherit_from_enclosing_scope as a heuristic to avoid checking deprecations prematurely. Now we're explicit about this.
Eric-Arellano
approved these changes
Aug 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed in v2, and simplifies the options handling code and tests quite a bit.
It also simplifies things for end users, who don't have to understand these concepts any more.
This should also improve invalidation, since scopes don't all inherit global scope options any more.
[ci skip-rust]
[ci skip-build-wheels]