Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Fix AWS breaking on Linux due to Python 2 usage #12364

Merged
merged 1 commit into from
Jul 16, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build-support/bin/install_aws_cli_for_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ source build-support/common.sh
AWS_CLI_ROOT="${HOME}/.aws_cli"
AWS_CLI_BIN="${AWS_CLI_ROOT}/bin/aws"

# We first check if AWS CLI is already installed thanks to Travis's cache.
if [[ ! -x "${AWS_CLI_BIN}" ]]; then

TMPDIR=$(mktemp -d)
Expand All @@ -23,7 +22,9 @@ if [[ ! -x "${AWS_CLI_BIN}" ]]; then

curl --fail "https://s3.amazonaws.com/aws-cli/awscli-bundle.zip" -o "awscli-bundle.zip"
unzip awscli-bundle.zip
./awscli-bundle/install --install-dir "${AWS_CLI_ROOT}"
# NB: We must run this with python3 because it defaults to `python`, which refers to Python 2 in Linux GitHub
# Actions CI job and is no longer supported.
python3 ./awscli-bundle/install --install-dir "${AWS_CLI_ROOT}"

popd

Expand Down