Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poetry_requirements handling of python. #12278

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jul 4, 2021

We now skip this entry since it is not representative of an actual
third party distribution requirement.

Fixes #12276

[ci skip-rust]
[ci skip-build-wheels]

We now skip this entry since it is not representative of an actual
third party distribution requirement.

Fixes pantsbuild#12276

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@jsirois jsirois requested review from Eric-Arellano and benjyw July 4, 2021 17:17
@jsirois jsirois merged commit 2a496aa into pantsbuild:main Jul 4, 2021
@jsirois jsirois deleted the issues/12276 branch July 4, 2021 19:10
jsirois added a commit to jsirois/pants that referenced this pull request Jul 5, 2021
We now skip this entry since it is not representative of an actual
third party distribution requirement.

Fixes pantsbuild#12276

(cherry picked from commit 2a496aa)

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
jsirois added a commit that referenced this pull request Jul 5, 2021
We now skip this entry since it is not representative of an actual
third party distribution requirement.

Fixes #12276

(cherry picked from commit 2a496aa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The poetry_requirements macro does not handle the special python dependency.
2 participants