Support building dists from an existing setup.py. #12250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
benjyw
force-pushed
the
use_existing_setup_script
branch
from
ba0761a to
dd369d8
Compare
|
Addresses #11942 . |
|
@nbren12 This is a step towards solving your use case. The remaining part is how to consume the package without having to publish it. |
|
Great! I'm glad this is being worked on. Compiling code in setup.py is quite common on the scientific python world. |
[ci skip-rust] [ci skip-build-wheels]
jsirois
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we insisted on generating the setup.py from information known to Pants.
This change allows users to build against an existing setup.py checked into the repo.
This is useful when the setup logic is unusual, or involves building native code, and so on.
Of course in this case there may be redundancy between the information known to Pants
and whatever is in the setup.py. So the author of the setup.py is responsible for ensuring that
it is correct with respect to versions, dependencies and so on.
This will make it easier to adopt Pants in an existing repo with existing setup.py files.
To use this new feature, your
provides=setup_py(...)stanza should contain asetup_scriptkey,pointing to the setup script, and it should also contain the
nameandversion, repeated fromthe setup.py. It may contain no other keys.
[ci skip-rust]
[ci skip-build-wheels]