Fix module_mapping to work regardless of capitalization and - vs _
#12068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
May 12, 2021
src/python/pants/backend/python/dependency_inference/default_module_mapping.py
Outdated
Show resolved
Hide resolved
jsirois
approved these changes
May 12, 2021
src/python/pants/backend/python/dependency_inference/default_module_mapping.py
Outdated
Show resolved
Hide resolved
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
force-pushed
the
apache-airflow
branch
from
b382da8 to
2854909
Compare
jsirois
reviewed
May 12, 2021
src/python/pants/backend/python/dependency_inference/default_module_mapping.py
Outdated
Show resolved
Hide resolved
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
May 13, 2021
…`_` (pantsbuild#12068) These all resolve to the same project: - my-req - my_req - MY_REQ Our `module_mapping` should not care about which format the original requirement string used. This also adds `apache-airflow` to our default mapping. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Sep 22, 2021
…d `poetry_requirements` (#12980) @riisi found in #12931 that the `module_mapping` was still case-sensitive, which we had intended to fix #12068. The first commit also refactors how we apply the `DEFAULT_MODULE_MAPPING` so that it's no longer stored on the `ModuleMappingField`, which makes `./pants peek` more useful. Related, we now set a default for the field so that `./pants peek --exclude-defaults` works. [ci skip-rust]
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Sep 22, 2021
…d `poetry_requirements` (Cherry-pick of pantsbuild#12980) @riisi found in pantsbuild#12931 that the `module_mapping` was still case-sensitive, which we had intended to fix pantsbuild#12068. The first commit also refactors how we apply the `DEFAULT_MODULE_MAPPING` so that it's no longer stored on the `ModuleMappingField`, which makes `./pants peek` more useful. Related, we now set a default for the field so that `./pants peek --exclude-defaults` works. [ci skip-rust] # Conflicts: # src/python/pants/backend/python/target_types.py # src/python/pants/backend/python/target_types_test.py
Eric-Arellano
added a commit
that referenced
this pull request
Sep 22, 2021
…d `poetry_requirements` (Cherry-pick of #12980) (#12981) @riisi found in #12931 that the `module_mapping` was still case-sensitive, which we had intended to fix #12068. The first commit also refactors how we apply the `DEFAULT_MODULE_MAPPING` so that it's no longer stored on the `ModuleMappingField`, which makes `./pants peek` more useful. Related, we now set a default for the field so that `./pants peek --exclude-defaults` works. [ci skip-rust]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These all resolve to the same project:
Our
module_mappingshould not care about which format the original requirement string used.This also adds
apache-airflowto our default mapping.[ci skip-rust]
[ci skip-build-wheels]