Fix PEX_ROOT leak run and repl goals. #12066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we'd leak `.cache/pex_root` to the workspace. Beyond making it easier to (mistakenly) corrupt the Pex cache for interactive Pex processes it also could degrade performance of those processes since this was not a symlink to the `pex_root` named cache used by sandboxed processes. Force user's of PexEnvironment methods that support setting up a process to declare what type of process they are setting up by moving those methods to CompletePexEnvironment with one concrete implementation for sandboxed processes and one for workspace processes. Fixes pantsbuild#12055 [ci skip-rust] [ci skip-build-wheels]
jsirois
commented
May 12, 2021
src/python/pants/backend/python/goals/run_pex_binary_integration_test.py
Show resolved
Hide resolved
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
May 12, 2021
There was a problem hiding this comment.
Thank you! This modeling looks good.
Could you please also cherry-pick to 2.5? I'll hold off on the release: #12065.
src/python/pants/backend/python/goals/run_pex_binary_integration_test.py
Show resolved
Hide resolved
Will do. |
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
May 12, 2021
Previously we'd leak `.cache/pex_root` to the workspace. Beyond making it easier to (mistakenly) corrupt the Pex cache for interactive Pex processes it also could degrade performance of those processes since this was not a symlink to the `pex_root` named cache used by sandboxed processes. Force user's of PexEnvironment methods that support setting up a process to declare what type of process they are setting up by moving those methods to CompletePexEnvironment with one concrete implementation for sandboxed processes and one for workspace processes. Fixes pantsbuild#12055 (cherry picked from commit 0a01eaf) # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
May 12, 2021
Previously we'd leak `.cache/pex_root` to the workspace. Beyond making it easier to (mistakenly) corrupt the Pex cache for interactive Pex processes it also could degrade performance of those processes since this was not a symlink to the `pex_root` named cache used by sandboxed processes. Force user's of PexEnvironment methods that support setting up a process to declare what type of process they are setting up by moving those methods to CompletePexEnvironment with one concrete implementation for sandboxed processes and one for workspace processes. Fixes pantsbuild#12055 (cherry picked from commit 0a01eaf) # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
added a commit
that referenced
this pull request
May 12, 2021
Previously we'd leak `.cache/pex_root` to the workspace. Beyond making it easier to (mistakenly) corrupt the Pex cache for interactive Pex processes it also could degrade performance of those processes since this was not a symlink to the `pex_root` named cache used by sandboxed processes. Force user's of PexEnvironment methods that support setting up a process to declare what type of process they are setting up by moving those methods to CompletePexEnvironment with one concrete implementation for sandboxed processes and one for workspace processes. Fixes #12055 (cherry picked from commit 0a01eaf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd leak
.cache/pex_rootto the workspace. Beyond making iteasier to (mistakenly) corrupt the Pex cache for interactive Pex processes
it also could degrade performance of those processes since this was not
a symlink to the
pex_rootnamed cache used by sandboxed processes.Force user's of PexEnvironment methods that support setting up a process
to declare what type of process they are setting up by moving those
methods to CompletePexEnvironment with one concrete implementation for
sandboxed processes and one for workspace processes.
Fixes #12055
[ci skip-rust]
[ci skip-build-wheels]