Allowpython_tests() to set environment variables
#12022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
May 6, 2021
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
May 6, 2021
Closes pantsbuild#11638 This adds support for designating environment variables at the `python_tests` level in a similar manner to how they can be currently [set at the global level](https://www.pantsbuild.org/docs/python-test-goal#setting-environment-variables). Variables set via `python_tests` will override those defined by `[tests].extra_env_vars`. [ci skip-rust]
|
Looks great! Thanks @rhysyngsun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11638
This adds support for designating environment variables at the
python_testslevel in a similar manner to how they can be currently set at the global level. Variables set viapython_testswill override those defined by[tests].extra_env_vars.