Fix a bug in unicode string dep inference. (cherrypick of #11879) #11881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11879) The dep extraction code calls print() to emit any imports and import-like strings it finds to stdout. print() uses a default encoding, which in some cases might be ascii, causing it to fail on non-ascii strings. This change replaces the naive call to print() with explicitly encoding the string as utf8 and writing the resulting raw bytes. [ci skip-rust] [ci skip-build-wheels]
jsirois
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dep extraction code calls print() to emit any imports and import-like strings it finds to stdout.
print() uses a default encoding, which in some cases might be ascii, causing it to fail on
non-ascii strings.
This change replaces the naive call to print() with explicitly encoding the string as utf8 and writing
the resulting raw bytes.
[ci skip-rust]
[ci skip-build-wheels]