Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect actual source root for generated files #11673

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Detect actual source root for generated files #11673

merged 1 commit into from
Mar 12, 2021

Conversation

jyggen
Copy link
Member

@jyggen jyggen commented Mar 11, 2021

Fixes #11666, with @Eric-Arellano doing all the heavy lifting :)

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you.

@Eric-Arellano Eric-Arellano requested review from benjyw and stuhood March 11, 2021 23:06
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Thanks for the patch.

@Eric-Arellano Eric-Arellano merged commit 6f1f8fc into pantsbuild:master Mar 12, 2021
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Mar 12, 2021
…ot` (pantsbuild#11673)

Fixes pantsbuild#11666.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Mar 12, 2021
…ot` (pantsbuild#11673)

Fixes pantsbuild#11666.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
stuhood pushed a commit that referenced this pull request Mar 12, 2021
Eric-Arellano added a commit that referenced this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python_source_root not added to syspath
3 participants