Stop pinning zipp by default in [pytest].pytest_plugins to reduce risk of issues with pip's new resolver
#11512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
asherf
approved these changes
Feb 2, 2021
stuhood
approved these changes
Feb 2, 2021
|
Iirc we had a performance issue with zipp. Was that why we pinned it? |
|
I think. Also they blithely dropped Py2 support. But we haven't noticed any performance issues and TC has been using it for a while now thanks to the constraints file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip's new resolver now errors when a constraints.txt value != an explicit requirement, such as one provided via
[pytest].pytest_plugins. This means that if a user haszippin their constraints.txt, they must either pin to the old2.1.0or they must override the default for[pytest].pytest_plugins. Both are very non-obvious what to do.We had pinned zipp as a convenience because it was unstable for some time, but it seems to have become more stable. It's been working robustly to use zipp 3.* in Toolchain. Now, this is likely to be much more of a gotcha and nuisance than a value-add to users. So, we stop pinning.
[ci skip-rust]
[ci skip-build-wheels]