[internal] Add toolchain plugin (disabled). #11287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asherf
changed the title
stuhood
approved these changes
Dec 9, 2020
| "toolchain.pants.buildsense.plugin==0.1.0", | ||
| ] | ||
|
|
||
| streaming_workunits_report_interval = 1 |
There was a problem hiding this comment.
This would probably make a better default than the current value. If you need to re-run this through CI, consider changing the default instead.
There was a problem hiding this comment.
I'll have a follow up PR to change the default for this and for run tracker options so we can remove those from pants.toml
|
|
||
| [auth] | ||
| from_env_var = "TOOLCHAIN_AUTH_TOKEN" | ||
| customer = "pantsbuild" |
There was a problem hiding this comment.
Nit: renaming this to user or org would be more neutral.
There was a problem hiding this comment.
this requires a new version of the plugin, I will be addressing that later on.
asherf
added a commit
to asherf/pants
that referenced
this pull request
Dec 21, 2020
This change upgrades to the new version of the Toolchain pants plugin (which was also renamed). There are a bunch of bug fixes and removed internal feature flags that are no longer needed. See pantsbuild#11287 (comment) for more context
asherf
added a commit
to asherf/pants
that referenced
this pull request
Dec 21, 2020
This change upgrades to the new version of the Toolchain pants plugin (which was also renamed). There are a bunch of bug fixes and removed internal feature flags that are no longer needed. See pantsbuild#11287 (comment) for more context
asherf
added a commit
to asherf/pants
that referenced
this pull request
Dec 22, 2020
This change upgrades to the new version of the Toolchain pants plugin (which was also renamed). There are a bunch of bug fixes and removed internal feature flags that are no longer needed. See pantsbuild#11287 (comment) for more context
stuhood
pushed a commit
that referenced
this pull request
Dec 22, 2020
This change upgrades to the new version of the Toolchain pants plugin (which was also renamed). There are a bunch of bug fixes and removed internal feature flags that are no longer needed. https://pypi.org/project/toolchain.pants.plugin/0.1.0/ See #11287 (comment) for more context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the toolchain plugin that collects pants metrics into the toolchain SaaS platform.
The plugin just loads, it is not enabled/running.
This change will allow further testing before enabling it in CI.
It will always be optional for local/desktop pants runs
This PR also configures travis to send webhooks to the Toolchain platform, those webhooks are used to enrich pants data by associating travis jobs data with pants run data in the Toolchain SaaS platform.