Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule_runner.py not being included in pantsbuild.pants.testutil #11257

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

Eric-Arellano
Copy link
Contributor

We were only including it by happenstance, thanks to a transitive dep. That transitive dep was removed in d3de097.

This adds a regression test.

[ci skip-rust]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
@Eric-Arellano Eric-Arellano requested a review from tdyas December 1, 2020 20:59
Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling fd94a81 on Eric-Arellano:fix-testutil into daaf30f on pantsbuild:master.

@Eric-Arellano Eric-Arellano merged commit 25c49f0 into pantsbuild:master Dec 1, 2020
@Eric-Arellano Eric-Arellano deleted the fix-testutil branch December 1, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants