Make S3 bucket expiry deletion handling robust. (#11156) #11161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now handle any number of deletions and unit test are added for this. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Nov 12, 2020
|
The CI failure here requires rebasing over the unrelated fix in #11166. |
The original deprecation value was a mistake and this fixes `./pants` on the 2.0.x branch which otherwise fails when bootstrapping options. [ci skip-rust] [ci skip-build-wheels]
|
Instead of rebasing I've inlined the fix here in 9981608 to get a green CI. |
Eric-Arellano
approved these changes
Nov 12, 2020
jsirois
deleted the
2.0.x/bootstrap_and_deploy_ci_pants_pex/handle_deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now handle any number of deletions and unit test are added for this.
[ci skip-rust]
[ci skip-build-wheels]