Improve performance of dependency inference #11094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
stuhood
reviewed
Nov 4, 2020
There was a problem hiding this comment.
Awesome!
performance of dependency inference by not digesting files
Note that this also improves performance because editing the content of a file should no longer invalidate the _StrippedFileNames value: PathGlob expansion does not depend on file content. So rebuilds should be faster!
src/python/pants/backend/python/dependency_inference/module_mapper.py
Outdated
Show resolved
Hide resolved
Comment on lines
+102
to
+107
| # NB: We use a custom implementation to resolve the stripped source paths, rather than | ||
| # `StrippedSourceFiles`, so that we can use `Get(Paths, PathGlobs)` instead of | ||
| # `Get(Snapshot, PathGlobs)`, which is much faster. | ||
| # | ||
| # This implementation is kept private because it's not fully comprehensive, such as not looking | ||
| # at codegen. That's fine for dep inference, but not in other contexts. |
There was a problem hiding this comment.
It's maybe worth referencing this implementation next to the other one, in case we recognize an opportunity to unify them?
stuhood
approved these changes
Nov 4, 2020
Eric-Arellano
changed the title
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
force-pushed
the
dep-inference-perf
branch
from
7831724 to
140256a
Compare
Eric-Arellano
added a commit
that referenced
this pull request
Nov 16, 2020
…` now that graph cycle is fixed (#11188) Closes #10917. This cycle made sense. We were trying to use `HydratedSources` in a dep inference rule when `HydratedSources` already uses dependencies. This is why with the rule for `-> Subtargets`, we were avoiding `HydratedSources` in the first place. #11094 ended up fixing this without us realizing. This PR also factors up `SourcesPaths` and `StrippedSourceFileNames`, which are the reason we were able to fix this cycle. We'll want to use these types in other places, such as #11184. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, 50 times:
After, 50 times:
[ci skip-rust]
[ci skip-build-wheels]