Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2.1.0.dev0 #11089

Merged
merged 4 commits into from
Oct 31, 2020
Merged

Prepare 2.1.0.dev0 #11089

merged 4 commits into from
Oct 31, 2020

Conversation

gshuflin
Copy link
Contributor

@gshuflin gshuflin commented Oct 30, 2020

[ci skip-rust]

[ci skip-build-wheels]
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on classifying those all as internal.

Comment on lines 26 to 27
* Add `:my_func` shorthand for the `entry_point` field (#11064)
`PR #11064 <https://github.com/pantsbuild/pants/pull/11064>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature

Comment on lines 44 to 45
* Deprecate the `compatibility` field in favor of `interpreter_constraints` (#11074)
`PR #11074 <https://github.com/pantsbuild/pants/pull/11074>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this at the very top because it's a new deprecation.


This document describes releases leading up to the ``2.1.x`` ``stable`` series.

See https://www.pantsbuild.org/v2.0/docs/release-notes-2-1 for an overview of the changes in this release, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See https://www.pantsbuild.org/v2.0/docs/release-notes-2-1 for an overview of the changes in this release, and
See https://www.pantsbuild.org/v2.1/docs/release-notes-2-1 for an overview of the changes in this release, and

The release notes will only be added to the new v2.1 branch of the site.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the , and part is bad. Did you mean to include the link to the plugin upgrade guide?

Comment on lines +59 to +63
* Deprecate the `platforms` field allowing a bare string (#11073)
`PR #11073 <https://github.com/pantsbuild/pants/pull/11073>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User API change

Comment on lines 69 to 70
* Add process return value as workunit metadata item (#11086)
`PR #11086 <https://github.com/pantsbuild/pants/pull/11086>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto on internal only.

Comment on lines 65 to 67
* Restore EngineAware metadata() method with non-cpython-reliant data structures (#11054)
`PR #11054 <https://github.com/pantsbuild/pants/pull/11054>`_
`PR #11047 <https://github.com/pantsbuild/pants/pull/11047>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an internal only change. Only Toolchain is consuming this API, as far as we know.

Comment on lines 78 to 79
* Do not error if `./pants package` does not match any targets (#11051)
`PR #11051 <https://github.com/pantsbuild/pants/pull/11051>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this under User API change, near the top (above the "remove" ones).

Comment on lines 81 to 82
* remove extraneous log statement (#11057)
`PR #11057 <https://github.com/pantsbuild/pants/pull/11057>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this never actually hit production, I think you can leave it off. That is, if we broke it at the start of dev0 but fixed before dev0.

(The reason we're leaving off changes now is to make the changelog less overwhelming for users upgrading)

Comment on lines -30 to -43
register(
"--provides-columns",
default="address,artifact_id",
help=(
"Display these columns when --provides is specified. Available columns are: "
"address, artifact_id, repo_name, repo_url, push_db_basedir"
),
removal_version="2.0.1.dev0",
removal_hint=(
"The option `--provides-columns` no longer does anything. It was specific to the "
"JVM backend, so no longer makes sense with Pants 2.0 initially only supporting "
"Python."
),
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks.

@coveralls
Copy link

coveralls commented Oct 30, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling ff4b10e on gshuflin:2.1.x into 4283b13 on pantsbuild:master.

Comment on lines 8 to 9
2.1.0.dev0 (10/30/2020)
----------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our (old?) rst rendering would have complained that the dashes aren't as long as the title here... maybe the PyPI rendering for wheels doesn't care.

Comment on lines +89 to +87
New Features
~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would put both New Features and Bugfixes above API Changes in future.

* Deprecate unused `run-tracker` options (#11038)
`PR #11038 <https://github.com/pantsbuild/pants/pull/11038>`_

* Add `[python-setup].resolver_http_cache_ttl` option (#10997)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature

* Validate that option scopes and target aliases don't collide. (#11004)
`PR #11004 <https://github.com/pantsbuild/pants/pull/11004>`_

* Add mechanism to deprecate target types and fields (#10966)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal only

* Add mechanism to deprecate target types and fields (#10966)
`PR #10966 <https://github.com/pantsbuild/pants/pull/10966>`_

* Automatically set setuptools interpreter constraints if unspecified (#10951)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix

* remote caching support (#10960)
`PR #10960 <https://github.com/pantsbuild/pants/pull/10960>`_

* Store per-run logs on RunTracker (#11025)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably internal only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any pants plugin writer can make use of this feature, even if it's only toolchain using it at the moment.

[ci skip-rust]
@gshuflin gshuflin merged commit bf5e789 into pantsbuild:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants