Account for requirement extras when parsing pipenv #10722

jperkelens · 2020-09-02T07:46:38Z

Problem

Recently introduced pipenv_requirements CAFO was not taking the 'extras' specified with a requirement (i.e pip install cloudprovider[aws]) into account when parsing the lockfile.

Solution

Inspects the requirement entry for an extras field and generates the python_requirement target appropriately.

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

coveralls · 2020-09-02T08:15:39Z

Coverage remained the same at 0.0% when pulling fea0baa on jperkelens:pipenv-extras into 6b79447 on pantsbuild:master.

Eric-Arellano

Thank you for fixing!

JP Erkelens added 2 commits September 2, 2020 03:37

Write test for extras

723ca0f

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Include extras when parsing pipenv

fea0baa

# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]

Eric-Arellano approved these changes Sep 2, 2020

View reviewed changes

Eric-Arellano merged commit 3c4a886 into pantsbuild:master Sep 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Account for requirement extras when parsing pipenv #10722

Account for requirement extras when parsing pipenv #10722

jperkelens commented Sep 2, 2020

coveralls commented Sep 2, 2020

Eric-Arellano left a comment

Account for requirement extras when parsing pipenv #10722

Account for requirement extras when parsing pipenv #10722

Conversation

jperkelens commented Sep 2, 2020

Problem

Solution

coveralls commented Sep 2, 2020

Eric-Arellano left a comment

Choose a reason for hiding this comment