Snapshots of single files store normalized paths. #10707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were not enforcing or normalizing relative paths. There are two callers, `DownloadedFile::load_or_download` and the `create_digest_to_digest` intrinsic. The former happens to always pass a normalized relative path due to the parsing behavior of `Url` but the latter did no validation or normalization taking a path string directly via cpython. A normalized relative path is now enforced by demanding a `RelativePath`. [ci skip-build-wheels]
|
An alternative to #10706. |
tdyas
approved these changes
Aug 30, 2020
|
The best fix may be in Stat/PathStat but I'm not sure enough about the contexts those deeper structures are used in to be sure those paths should always be relative. I'll be happy to circle back if this validation can be pushed deeper. |
|
This should also fix the Buildgrid test in remote-apis-testing which encountered a similar error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were not enforcing or normalizing relative paths. There
are two callers,
DownloadedFile::load_or_downloadand thecreate_digest_to_digestintrinsic. The former happens to always pass anormalized relative path due to the parsing behavior of
Urlbut thelatter did no validation or normalization taking a path string directly
via cpython. A normalized relative path is now enforced by demanding a
RelativePath.[ci skip-build-wheels]