Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech debt] Remove blacklist for pex resolver #5696

Closed
CMLivingston opened this issue Apr 13, 2018 · 0 comments
Closed

[Tech debt] Remove blacklist for pex resolver #5696

CMLivingston opened this issue Apr 13, 2018 · 0 comments
Assignees
@jsirois

Comments

@CMLivingston
Copy link
Contributor

See pex-tool/pex#456 for full problem statement. TL;DR: the pex resolver errors on PEP508 environment markers when resolving for an incompatible interpreter. A common use case for such markers is to ensure backport libraries are installed for universal wheels.

The second part of this stopgap is to allow for the definition of a blacklist for the pex resolver in pants.ini. The scope of this ticket is to revert the Pant-specific portion of these stopgap measures once someone (myself, most likely) implements and merges pex-tool/pex#456.
@CMLivingston CMLivingston mentioned this issue Apr 13, 2018
Merged
@jsirois jsirois self-assigned this Oct 9, 2018
jsirois added a commit to jsirois/pants that referenced this issue Oct 9, 2018
@jsirois
Upgrade to pex 1.5.0; ~kill --resolver-blacklist.
1344ade 
PEX now handles blacklisting for us by respecting PEP-508 enviornment
markers.

Fixes pantsbuild#5696
@jsirois jsirois mentioned this issue Oct 9, 2018
Closed
jsirois added a commit to jsirois/pants that referenced this issue Oct 11, 2018
@jsirois
Upgrade to pex 1.5.1; ~kill --resolver-blacklist.
50f7c36 
PEX now handles blacklisting for us by respecting PEP-508 enviornment
markers.

Fixes pantsbuild#5696
@jsirois jsirois mentioned this issue Oct 11, 2018
Merged
jsirois added a commit that referenced this issue Oct 11, 2018
@jsirois
Upgrade to pex 1.5.1; ~kill --resolver-blacklist. (#6619)
eb59efd 
PEX now handles blacklisting for us by respecting PEP-508 enviornment
markers.

Fixes #5696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsirois @CMLivingston