Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings to 2.24 about scie-pants/Python 3.11 #21603

Closed
huonw opened this issue Nov 1, 2024 · 1 comment · Fixed by #21726
Closed

Add deprecation warnings to 2.24 about scie-pants/Python 3.11 #21603

huonw opened this issue Nov 1, 2024 · 1 comment · Fixed by #21726
Assignees
Labels
diagnostics Poor diagnostics, error messages that could be improved

Comments

@huonw
Copy link
Contributor

huonw commented Nov 1, 2024

I'm not opposed to some sort of warn-but-not-too-often in 2.24, I'm just not sure exactly what that looks like. Best effort to do something by 2.24.0 as we learn more in main sounds okay to me.

Originally posted by @cburroughs in #21528 (comment)

@huonw huonw changed the title Add deprecation warnings to 2.24 about scie-pants/Pyhthon 3.11 Add deprecation warnings to 2.24 about scie-pants/Python 3.11 Nov 1, 2024
@huonw
Copy link
Contributor Author

huonw commented Nov 21, 2024

Case report: running with a too old scie-pants on my machine gave this error:

Failed to fetch https://github.com/pantsbuild/pants/releases/download/release_2.25.0.dev0/pants.2.25.0.dev0-cp39-darwin_arm64.pex: [22] HTTP response code said error (The requested URL returned error: 404)
Wasn't able to fetch the Pants PEX at https://github.com/pantsbuild/pants/releases/download/release_2.25.0.dev0/pants.2.25.0.dev0-cp39-darwin_arm64.pex.

Check to see if the URL is reachable (i.e. GitHub isn't down) and if pants.2.25.0.dev0-cp39-darwin_arm64.pex asset exists within the release. If the asset doesn't exist it may be that this platform isn't yet supported. If that's the case, please reach out on Slack: https://www.pantsbuild.org/docs/getting-help#slack or file an issue on GitHub: https://github.com/pantsbuild/pants/issues/new/choose.

Exception:

Command '['/Users/huon/Library/Caches/nce/161eac8bd1cd5862947ecfaaa25e9c9fea11cede0c697ae76f76f0b4789e2da5/ptex-macos-aarch64', 'https://github.com/pantsbuild/pants/releases/download/release_2.25.0.dev0/pants.2.25.0.dev0-cp39-darwin_arm64.pex']' returned non-zero exit status 1.
Error: Failed to establish atomic directory /Users/huon/Library/Caches/nce/f46d2c12132bad9c27e0dd509186c190371abfe1add7e5ca42245466f35bea81/locks/install-dfd5d377be1d503206740187809bf4b2c3b2e3c9d1911cfa26254264e60b02b6. Population of work directory failed: Boot binding command failed: exit status: 1

Isolates your Pants from the elements.

Please select from the following boot commands:

<default> (when SCIE_BOOT is not set in the environment)  Detects the current Pants installation and launches it.
bootstrap-tools                                           Introspection tools for the Pants bootstrap process.
update                                                    Update scie-pants.

You can select a boot command by setting the SCIE_BOOT environment variable.

It's... not obvious to me at all that the right solution here is upgrading the scie-pants tool; I think we do need to do something here for Pants 2.24

@huonw huonw self-assigned this Dec 6, 2024
@huonw huonw added the diagnostics Poor diagnostics, error messages that could be improved label Dec 6, 2024
cburroughs pushed a commit that referenced this issue Dec 6, 2024
…21726)

This makes two changes:

- upgrades the "upgrading pants" docs call out into a dedicated/linkable
section, and calls out that the package manager can be used to upgrade
too
- institutes an deprecation warning when running with scie-pants older
than 0.12.2

This'll be cherrypicked to 2.24 to get ahead of the upgrade experience
of going from 2.24 to 2.25.

Fixes #21603
cburroughs pushed a commit to cburroughs/pants that referenced this issue Dec 6, 2024
…antsbuild#21726)

This makes two changes:

- upgrades the "upgrading pants" docs call out into a dedicated/linkable
section, and calls out that the package manager can be used to upgrade
too
- institutes an deprecation warning when running with scie-pants older
than 0.12.2

This'll be cherrypicked to 2.24 to get ahead of the upgrade experience
of going from 2.24 to 2.25.

Fixes pantsbuild#21603
cburroughs added a commit that referenced this issue Dec 6, 2024
…herry-pick of #21726) (#21731)

This makes two changes:

- upgrades the "upgrading pants" docs call out into a dedicated/linkable
section, and calls out that the package manager can be used to upgrade
too
- institutes an deprecation warning when running with scie-pants older
than 0.12.2

This'll be cherrypicked to 2.24 to get ahead of the upgrade experience
of going from 2.24 to 2.25.

Fixes #21603

Co-authored-by: Huon Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics Poor diagnostics, error messages that could be improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant