Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryNotFoundError complaining about Python, even though pants.backend.python.providers.experimental.pyenv is enabled #19160

Closed
thejcannon opened this issue May 25, 2023 · 3 comments · Fixed by #19208
Closed

BinaryNotFoundError complaining about Python, even though pants.backend.python.providers.experimental.pyenv is enabled #19160

thejcannon opened this issue May 25, 2023 · 3 comments · Fixed by #19208
Assignees
@thejcannon
Labels
backend: Python Python backend-related issues bug
Milestone
2.16.x

Comments

@thejcannon
Copy link
Member

Describe the bug

  • Enable pants.backend.python.providers.experimental.pyenv
  • Use a docker_environment with a Python that isn't Py3, like ubuntu:bionic

You'll see the error. This is likely because get_pyenv_install_info is using PythonBinary, when it should likely be PythonBuildStandaloneBinary

Pants version
2.16.0rc2

OS
(Docker linux)

Additional info
:/
@thejcannon thejcannon added the bug label May 25, 2023
@thejcannon thejcannon added this to the 2.16.x milestone May 25, 2023
@thejcannon
Copy link
Member Author

I don't remember all the intricacies of when and when not we have Python. @stuhood it's likely we just leave this as a bug until 2.18.x where scie-pants is the only runner, and switch everything to assuming PBS.

@da-tubi da-tubi added the backend: Python Python backend-related issues label May 26, 2023
@thejcannon
Copy link
Member Author

Wait, no this can be backported because PBS is a misnomer and is ok to use.

@thejcannon
Copy link
Member Author

Yeah I think this was an oversight (or meant to be a follow up of) #18433

😮‍💨

@thejcannon thejcannon self-assigned this May 30, 2023
This was referenced May 30, 2023
Closed
Merged
thejcannon added a commit that referenced this issue Jun 1, 2023
@thejcannon
Avoid requiring Python when trying to install Python (using Pyenv) (#…
5b01f37 
…19208)

Fixes #19160 by switching
`PythonBinary` input type to `PythonBuildStandaloneBinary`
github-actions bot pushed a commit that referenced this issue Jun 1, 2023
@thejcannon @WorkerPants
Avoid requiring Python when trying to install Python (using Pyenv) (#…
d228ebb 
…19208)

Fixes #19160 by switching
`PythonBinary` input type to `PythonBuildStandaloneBinary`
@WorkerPants WorkerPants mentioned this issue Jun 1, 2023
Merged
github-actions bot pushed a commit that referenced this issue Jun 1, 2023
@thejcannon @WorkerPants
Avoid requiring Python when trying to install Python (using Pyenv) (#…
a614ac3 
…19208)

Fixes #19160 by switching
`PythonBinary` input type to `PythonBuildStandaloneBinary`
@WorkerPants WorkerPants mentioned this issue Jun 1, 2023
Merged
thejcannon added a commit that referenced this issue Jun 1, 2023
@WorkerPants @thejcannon
Avoid requiring Python when trying to install Python (using Pyenv) (C…
88952f8 
…herry-pick of #19208) (#19215)

Fixes #19160 by switching
`PythonBinary` input type to `PythonBuildStandaloneBinary`

Co-authored-by: Joshua Cannon <[email protected]>
thejcannon added a commit that referenced this issue Jun 1, 2023
@WorkerPants @thejcannon
Avoid requiring Python when trying to install Python (using Pyenv) (C…
85eefb5 
…herry-pick of #19208) (#19214)

Fixes #19160 by switching
`PythonBinary` input type to `PythonBuildStandaloneBinary`

Co-authored-by: Joshua Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thejcannon thejcannon

Labels
backend: Python Python backend-related issues bug
Projects
None yet
Milestone
2.16.x
2 participants
@thejcannon @da-tubi