Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Path path/to/thing was a file rather than a symlink." #18956

Closed
thejcannon opened this issue May 9, 2023 · 4 comments · Fixed by #18963
Closed

"Path path/to/thing was a file rather than a symlink." #18956

thejcannon opened this issue May 9, 2023 · 4 comments · Fixed by #18963
Labels
bug
Milestone
2.16.x

Comments

@thejcannon
Copy link
Member

thejcannon commented May 9, 2023 •
edited
Loading

Describe the bug
Trying out 2.16.0rc1 I see:

$ pants export-codegen <thing>
...
IntrinsicError: Error matching globs against DirectoryDigest { digest: Digest { hash: Fingerprint<50618ba5af055a5510a25a92a95755d58c2a50c2c3bcb1da35fcda0b479583e6>, size_bytes: 78 }, tree: "Some(..)" }: Path `deps/libs/openfst/lib/fst/ngram-fst.so` was a file rather than a symlink.

Pants version
2.16.0rc1

OS
Linux

Additional info
The error is stemming from a shell_command is is unpacking a tar.
@thejcannon thejcannon added the bug label May 9, 2023
@thejcannon
Copy link
Member Author

This happens even if I specify --local-store-dir=$HOME/lmdb_store2

@thejcannon thejcannon added this to the 2.16.x milestone May 9, 2023
@thejcannon
Copy link
Member Author

Oh fun. I can't reproduce inside the Pants repo (so using 2.17.x)

@huonw
Copy link
Contributor

huonw commented May 9, 2023 •
edited
Loading

There's been some symlink related changes since rc1, like #18873 (was cherry-picked). Maybe it's fixed on 2.16.x / in rc2 when that comes out...

That said, not sure how that error would appear...

@thejcannon
Copy link
Member Author

OK --print-stacktrace was key to seeing that this is because of experimental_wrap_as_resources -> digest_subset_to_digest intrinsic. Will push on

@thejcannon thejcannon mentioned this issue May 10, 2023
Merged
thejcannon added a commit that referenced this issue May 11, 2023
@thejcannon
Make DigestSubset symlink-aware (#18963)
bee75a9 
Fixes #18956

Added a new test. Fails before, passes after!
@thejcannon thejcannon mentioned this issue May 11, 2023
Merged
thejcannon added a commit to thejcannon/pants that referenced this issue May 11, 2023
@thejcannon
Make DigestSubset symlink-aware (pantsbuild#18963)
1b42621 
Fixes pantsbuild#18956

Added a new test. Fails before, passes after!
thejcannon added a commit that referenced this issue May 11, 2023
@thejcannon
Make DigestSubset symlink-aware (Cherry-pick of #18963) (#18970)
e22b418 
Fixes #18956

Added a new test. Fails before, passes after!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.16.x
Development

Successfully merging a pull request may close this issue.

Make DigestSubset symlink-aware thejcannon/pants
2 participants
@huonw @thejcannon