Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunTracker.end_run not called for abnormal exits #11788

Closed
stuhood opened this issue Mar 24, 2021 · 0 comments · Fixed by #11793
Closed

RunTracker.end_run not called for abnormal exits #11788

stuhood opened this issue Mar 24, 2021 · 0 comments · Fixed by #11793
Assignees
@stuhood
Labels
bug

Comments

@stuhood
Copy link
Member

stuhood commented Mar 24, 2021

Currently RunTracker.end_run is not called:

  • for ./pants help (or any other run that invokes the HelpPrinter rather than LocalPantsRunner)
  • when a run is killed with Ctrl+C
@stuhood stuhood added the bug label Mar 24, 2021
@stuhood stuhood self-assigned this Mar 24, 2021
@stuhood stuhood added this to the 2.4.x milestone Mar 24, 2021
stuhood added a commit to stuhood/pants that referenced this issue Mar 25, 2021
@stuhood
Add failing tests of the cases in pantsbuild#11788.
9660788 
[ci skip-rust]

[ci skip-build-wheels]
@stuhood stuhood mentioned this issue Mar 25, 2021
Merged
stuhood added a commit to stuhood/pants that referenced this issue Mar 25, 2021
@stuhood
Add failing tests of the cases in pantsbuild#11788.
986ad67 
[ci skip-rust]

[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this issue Mar 25, 2021
@stuhood
Add failing tests of the cases in pantsbuild#11788.
594a29e 
[ci skip-rust]

[ci skip-build-wheels]
stuhood added a commit that referenced this issue Mar 25, 2021
@stuhood
Ensure that metrics are gathered during abnormal exits (#11793)
baf2429 
### Problem

As described in #11788, `RunTracker.end_run` is not called for `help`, runs with no goals, or runs that end in `Ctrl+C`. This can prevent metrics gathering.

### Solution

Adjust `LocalPantsRunner` to ensure that the run is ended in the `RunTracker` before the `StreamingWorkunitHandler` is torn down.

### Result

Fixes #11788.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuhood stuhood

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that metrics are gathered during abnormal exits stuhood/pants
1 participant
@stuhood