Skip to content

Commit

Permalink
Default to an empty OptionsBootstrapper on initial setup
Browse files Browse the repository at this point in the history
[ci skip-rust]
[ci skip-build-wheels]
  • Loading branch information
Eric-Arellano committed Sep 25, 2020
1 parent 9d7064b commit 778fdf8
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/python/pants/engine/internals/build_files_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import re
from textwrap import dedent
from typing import Iterable, Optional, Set, cast
from typing import Iterable, Set, cast

import pytest

Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/engine/internals/graph_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from dataclasses import dataclass
from pathlib import PurePath
from textwrap import dedent
from typing import Iterable, List, Optional, Set, Tuple, Type
from typing import Iterable, List, Set, Tuple, Type

import pytest

Expand Down
1 change: 0 additions & 1 deletion src/python/pants/engine/internals/options_parsing_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from pants.engine.rules import SubsystemRule
from pants.option.scope import GLOBAL_SCOPE, Scope, ScopedOptions
from pants.python.python_setup import PythonSetup
from pants.testutil.option_util import create_options_bootstrapper
from pants.testutil.rule_runner import QueryRule, RuleRunner
from pants.util.logging import LogLevel

Expand Down
6 changes: 5 additions & 1 deletion src/python/pants/testutil/rule_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,11 @@ def __init__(
build_root=self.build_root,
build_configuration=self.build_config,
execution_options=ExecutionOptions.from_bootstrap_options(global_options),
).new_session(build_id="buildid_for_test", should_report_workunits=True)
).new_session(
build_id="buildid_for_test",
session_values=SessionValues({OptionsBootstrapper: create_options_bootstrapper()}),
should_report_workunits=True,
)
self.scheduler = graph_session.scheduler_session

def __repr__(self) -> str:
Expand Down

0 comments on commit 778fdf8

Please sign in to comment.