Skip to content

Commit

Permalink
Remove tensorboard mapping from our default mapping (#19673)
Browse files Browse the repository at this point in the history
`torch.utils.tensorboard` imports `tensorboard` (or dies trying). The
original intent is "if a file imports it, it should receive a dependency
on `tensorboard`". Unfortunately the actual behavior is that _only_
tensorboard is inferred (and not `torch`). Worse, an import from
`tensorboard` is now ambiguous (because it's missing from the value).

So we'll remove it and cherry-pick to 2.17.x (when it was introduced).
Later we can fix the underlying issue of being able to model an import
mapping to multiple packages.

See #19672
  • Loading branch information
thejcannon authored and huonw committed Aug 26, 2023
1 parent 3bf4fb7 commit 192eb2d
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@
"snowflake-connector-python": ("snowflake.connector",),
"strawberry-graphql": ("strawberry",),
"streamlit-aggrid": ("st_aggrid",),
"tensorboard": ("torch.utils.tensorboard",),
"websocket-client": ("websocket",),
}

Expand Down

0 comments on commit 192eb2d

Please sign in to comment.