Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugger not starting for junit tests #515

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix debugger not starting for junit tests #515

merged 1 commit into from
Apr 8, 2020

Conversation

mzarnowski
Copy link
Contributor

No description provided.

@mzarnowski
Copy link
Contributor Author

Note, that the new pants master introduced a failure in com.twitter.intellij.pants.integration.OSSPantsCompileActionsTest#testLintTargetAction. It will be handled in a separate PR and after it gets merged, I will rebase this one.

@mzarnowski
Copy link
Contributor Author

Note, that the new pants master introduced a failure in com.twitter.intellij.pants.integration.OSSPantsCompileActionsTest#testLintTargetAction

And yet, it didn't fail on the CI. I have confirmed with @tpasternak that this error did not happen on his machine, so I think it is best to assume that the problem is somewhere on my local machine and the PR can be considered merge-ready.

Copy link
Collaborator

@wisechengyi wisechengyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks, @marek1840.

@wisechengyi wisechengyi merged commit 924f62d into pantsbuild:master Apr 8, 2020
@olafurpg
Copy link
Contributor

olafurpg commented Apr 8, 2020

Do we need a new pants plugin release to get this distributed via MDE?

@mzarnowski mzarnowski deleted the debug/user-user-data-to-enable-debugging branch April 23, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants