Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Idea 201.6073.9 #501

Merged
merged 14 commits into from
Mar 20, 2020
Merged

Support for Idea 201.6073.9 #501

merged 14 commits into from
Mar 20, 2020

Conversation

mzarnowski
Copy link
Contributor

No description provided.

tpasternak
tpasternak reviewed Mar 12, 2020
View reviewed changes
common/com/twitter/intellij/pants/util/PantsUtil.java Outdated
@@ -979,4 +980,15 @@ public static void invalidatePluginCaches() {
public static List<String> parseCmdParameters(Optional<String> cmdArgsLine) {
return cmdArgsLine.map(ParametersListUtil::parse).orElse(ContainerUtil.newArrayList());
}

public static void invokeLater(Runnable task) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's rename it if it's not always "later"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to invokeLaterIfNeeded to maintain compatibility with the underlying idea method

@tpasternak tpasternak mentioned this pull request Mar 13, 2020
Merged
@mzarnowski mzarnowski marked this pull request as ready for review March 13, 2020 14:30
wisechengyi
wisechengyi reviewed Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@wisechengyi wisechengyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, modulo https://virtuslab.slack.com/archives/GPW0LR35H/p1584407182117200

@olafurpg
Copy link
Contributor

Not sure if it's relevant here, but got a message from the Scala plugin team that there have been some internal breaking changes

If you have plugins for IDEA that depend on Scala plugin compiler or somehow rely on it's behaviour, please check that all is working in 2020.1 EAP. There wer some changes in that area

@mzarnowski
Copy link
Contributor Author

there have been some internal breaking changes in Scala plugin

I haven't noticed anything unusual when working on this update, so let's hope those don't affect us here.

wisechengyi
wisechengyi approved these changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@wisechengyi wisechengyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marek1840 !

@wisechengyi wisechengyi merged commit 5c5b203 into pantsbuild:master Mar 20, 2020
@mzarnowski mzarnowski deleted the update/idea-201.6073.9 branch April 23, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpasternak tpasternak tpasternak left review comments

@wisechengyi wisechengyi wisechengyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzarnowski @olafurpg @wisechengyi @tpasternak