Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save incremental import depth setting #479

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Save incremental import depth setting #479

merged 2 commits into from
Mar 10, 2020

Conversation

tpasternak
Copy link
Contributor

This commit was already merged to master, but reverted due to #471

ORIGINAL MESSAGE:

Before this commit, IntelliJ plugin was asking for incremental import
depth each time, even when doing refresh. The depth value was not
saved anywhere.

Now, the incremental import depth parameter is saved alongside other
settings, and may be configured in the same place as others.

@tpasternak tpasternak marked this pull request as ready for review January 16, 2020 11:47
@wisechengyi
Copy link
Collaborator

Bump. CI has been fixed. Thanks!

Tomasz Pasternak added 2 commits February 25, 2020 14:47
Before this commit, IntelliJ plugin was asking for incremental import
depth each time, even when doing refresh. The depth value was not
saved anywhere.

Now, the incremental import depth parameter is saved alongside other
settings, and may be configured in the same place as others.
@tpasternak
Copy link
Contributor Author

Is this still needed?

@wisechengyi
Copy link
Collaborator

Yes, sorry! Merging.

@wisechengyi wisechengyi merged commit 1f72954 into pantsbuild:master Mar 10, 2020
@tpasternak
Copy link
Contributor Author

Np :) thanks

wisechengyi pushed a commit that referenced this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants