Create libraries for non python target when import dep as jar #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…import dep as jar' is in use (pantsbuild#468)
Before this commit, the list of the targets were stored in `PantsProjectSettings::myTargetSpecs` field. Unfortunately, this list was based on the contents of `myTargetSpecsBox` widget, which was cleared each time when the "Pants->Settings" window was opened. As a result, the list of targets was cleared each time during settings save. The fix to this is just not to clean the list of targets in the window. But this led to a new issue. When the list of targets is presented to the user, it's also possible for him to deselect target. During save, the `myTargetSpecs` variable was based on the list of selected targets, so after deselection and save, it was not possible to select it again. In order to overcome this, I put two lists to `PantsProjectSettings` instead of `myTargetSpecs`: 1. `allAvailableTargetSpecs` - used to build `myTargetSpecsBox` widget 2. `selectedTargetSpecs` - to inform `pants` which targets it should operate on fixes pantsbuild#457
wisechengyi
changed the title
wisechengyi
changed the title
wisechengyi
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow-up change to pantsbuild/pants#8812.
Problem
Since we will now be relying on libraries as a mechanism to express dependencies between targets, we need to process the libraries field for jvm executables as well.
Solution
Relax the filter in
PantsLibrariesExtensionto process any scala target (not just JarLibraries).Result:
In combination with the pants PR above, the following UX is achieved:
pantsbuild/pants#8812 (comment)