Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save incremental import depth #462

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Save incremental import depth #462

merged 1 commit into from
Jan 1, 2020

Conversation

tpasternak
Copy link
Contributor

Before this commit, IntelliJ plugin was asking for incremental import
depth each time, even when doing refresh. The depth value was not
saved anywhere.

Now, the incremental import depth parameter is saved alongside other
settings, and may be configured in the same place as others.

Before this commit, IntelliJ plugin was asking for incremental import
depth each time, even when doing refresh. The depth value was not
saved anywhere.

Now, the incremental import depth parameter is saved alongside other
settings, and may be configured in the same place as others.
@tpasternak tpasternak marked this pull request as ready for review December 20, 2019 11:21
Copy link
Collaborator

@wisechengyi wisechengyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, @tpasternak !

@wisechengyi wisechengyi merged commit 3fc07d4 into pantsbuild:master Jan 1, 2020
wisechengyi added a commit to wisechengyi/intellij-pants-plugin that referenced this pull request Jan 6, 2020
wisechengyi added a commit that referenced this pull request Jan 6, 2020
* Revert "Save incremental import depth setting (#462)"

This reverts commit 3fc07d4.

* Revert "Don't drop list of targets while saving settings (#458)"

This reverts commit 58d0b40.

Due to #471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants