Recover from incorrect JDK #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisechengyi
reviewed
Nov 23, 2019
There was a problem hiding this comment.
Thanks, Marek!
The issue seems a bit trickier than it appears, because there are two symlink redirections in our configuration, but it doesn't make much sense for the plugin to detect the chain of symlinks IMO, e.g.
1.
# ls -l /Library/Java/JavaVirtualMachines/TwitterJDK
lrwxr-xr-x 1 root wheel 40 Nov 23 13:28 /Library/Java/JavaVirtualMachines/TwitterJDK -> /opt/twitter_mde/package/TwitterJDK/current
# ls -l /opt/twitter_mde/package/TwitterJDK/current
lrwxr-xr-x 1 root managed_dev_env 3 Nov 23 13:14 /opt/twitter_mde/package/TwitterJDK/current -> xyz
So, I was thinking instead of detecting and changing the SDK automatically, how about we make it an action called Refresh Pants Project SDK under the Pants menu, leaving it to user to decide when to trigger the refresh the SDK configuration?
The status quo was
- User has to remove the existing SDK
- Reimport the project which then recreates the SDK
With the improvement, user only needs to trigger the Refresh Pants Project SDK while the project is open.
That sounds way simpler, so than relying on some automagic, so I agree it might be preferable. |
|
Looks like this the refresh action is running on the UI thread, causing: |
|
Would it possible that this does not run on the EDT thread?
|
|
I have missed one spot where a heavy action was running on the UI thread, now it should be good.
Is your intention here to change the invalidate action to run on non-UI thread? Were there any freezes or errors with the invalidate action? |
|
invalidate action itself is super quick, so your change should suffice. I will double check when back online. |
patliu85
approved these changes
Dec 5, 2019
wisechengyi
approved these changes
Dec 5, 2019
Previously, the refresh was happening on the EDT thread which caused errors and freezes because of a process being started inside the "createPantsJdk" call. As a result of running in the background, changing the project JDK (if it wasn't a pants' one) must be scheduled to run in a dispatcher thread.
Getting the default JDK might take a long time if there is no pants JDK present and export cache is empty as we have to run an external process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "Refresh Pants Project SDK" action to Pants drop-down menu.
When activated, this action will refresh the sdk of the current project.
If the SDK is not set or is not a pants-generated one, a pants SDK will be generated if needed and set as a project's SDK. If it already is a pants-generated SDK, it will be regenerated.