-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up .ij.import.rc file for dynamic pantsrc insertion #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first thought here is: why not just directly use pants' rc files? Basically the equivalent of:
|
Ah good idea! The only thing is that using pantsrc cannot remove any command line args the plugin passes to pants due to ranked value, but that should not really be an issue. |
Adjusted. |
Merging this one since it's a relatively simple change. Like before, if there is any issue, I can do a follow up patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently all the pants command args from intellij pants plugin are hardcoded from the plugin, so we do not have a way to dynamically tweak per repo, which would be useful if when we want to inject flags for experimental pants features, debug flags, etc.
Solution
Add a mechanism to recognize /.ij.import.rc file for dynamic argument changes per repo.