-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve exception messages used within import dialog #314
Merged
wisechengyi
merged 17 commits into
pantsbuild:master
from
cosmicexplorer:dmcclanahan/improve-error-message-startup
Oct 5, 2017
+186
−38
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ee86ef4
improve error messages in .listAllTargets()
097f842
add new scala plugin checksum
6935c3e
cancel import after failed pants list
3f0cdd9
Merge branch 'master' into dmcclanahan/improve-error-message-startup
ec4a31f
clarify purpose of new test data
d7ce35d
revert unnecessary formatting change
9192636
address review comments
7a902ce
fix compile errors
abda473
refactor .listAllTargets() and add tests for changes
ffecffe
fix relative path to invalid-build-file
c04a237
remove unnecessary name change
21e450b
address review comments
87c96f8
refactor invalid import targets (tests should FAIL!)
60d650a
remove intentional failing assertion in setUp()
da5f43b
add verification of exception message
429f25b
fix exception message assertion and ensure exception class shown
2ad0787
make assertion message more clear
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix relative path to invalid-build-file
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably use something like https://github.com/wisechengyi/intellij-pants-plugin/blob/540e81a0b001aac8bbdef23dd966804d60cc3f4f/testFramework/com/twitter/intellij/pants/testFramework/PantsTestUtils.java#L16 to get testData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, I'll try to make this cleaner.