Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve exception messages used within import dialog #314

Merged
Prev Previous commit
Next Next commit
fix relative path to invalid-build-file
Daniel McClanahan committed Oct 3, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit ffecffe942617373fdc8102f09dc459a608d1c04
2 changes: 1 addition & 1 deletion tests/com/twitter/intellij/pants/util/PantsUtilTest.java
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ public void testListTargetsNonexistentBuildFile() {
public void testListTargetInvalidBuildFile() {
String projectDir = getProjectFolder().getPath();
Path invalidBuildFilePath = Paths.get(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I'll try to make this cleaner.

projectDir, "..", "invalid-build-file", "BUILD");
projectDir, "../../testData/invalid-build-file/BUILD");
String invalidBuildFileLocation = invalidBuildFilePath.normalize().toString();
File invalidBuildFile = new File(invalidBuildFileLocation);
assertTrue(invalidBuildFile.exists() && !invalidBuildFile.isDirectory());