Release 1.6.1 with automation #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisechengyi
changed the title
baroquebobcat
approved these changes
May 9, 2017
scripts/deploy/deploy.py
Outdated
| subprocess.check_output('git checkout {}'.format(PLUGIN_XML), shell=True) | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('--tag', type=str, default='') | ||
| args = parser.parse_args() |
There was a problem hiding this comment.
Could you add a short description?
scripts/deploy/deploy.py
Outdated
| channel = CHANNEL_BLEEDING_EDGE | ||
|
|
||
| sha = get_head_sha() | ||
| logger.info('Append git sha {} to plugin version'.format(sha)) |
There was a problem hiding this comment.
How about Appending current git sha, {}, to plugin version?
There was a problem hiding this comment.
refined. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Earlier the manual release into Stable channel missed certain classfiles, because not having Scala SDK set correctly in the intellij project of this repo caused compilation to miss all the scala files and passed only with warnings.
Solution
Add 'stable' channel into the release automation script as well, so from now on there should be no need to manually build and upload jars to Jetbrains plugin repo anymore.
Result
Example run can be seen at https://travis-ci.org/wisechengyi/intellij-pants-plugin/jobs/230219448
Notable changes from 1.6.0