Event based project view focusing #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wisechengyi
added a commit
that referenced
this pull request
Mar 2, 2017
# Changes notes ## Bug fixes * Remove import redundancy; Fix project setting UI (#246) * Fix language level not set (#249) * Fix JDK not set correctly from idea-plugin import (#267) ## Performance * Skip looking for JDK when there is one set already (#261) * Event based project view focusing (#263) ## Usability * Add ability to cancel Pants process (#258) ## Metrics * Capture indexing duration on the fly (#265) * Log noop PantsCompile and duration between PantsCompile invocation and last file edit (#241)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously once project import starts, the code will check periodically whether the project is ready in order to zoom into the import directory, causing GUI to be sluggish every second before project is finally loaded.
Solution
I have found the right event to subscribe, so zooming will only happen after the project is loaded.
Other change
Enable test on zooming.
Clarify code on variable meaning.