Skip to content

Commit

Permalink
Add --no-quiet to Pants export call (#321)
Browse files Browse the repository at this point in the history
so Pants will show the error messages if there are any instead of suppressing them.

There is no effect on how the result is parsed because the json output is written into a file.
  • Loading branch information
wisechengyi authored Nov 20, 2017
1 parent b2a024a commit f4f2f99
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public static SimpleExportResult getExportResult(@NotNull String pantsExecutable
return cache;
}
final GeneralCommandLine commandline = PantsUtil.defaultCommandLine(pantsExecutable);
commandline.addParameters("export", PantsConstants.PANTS_CLI_OPTION_NO_COLORS);
commandline.addParameters("--no-quiet", "export", PantsConstants.PANTS_CLI_OPTION_NO_COLORS);
try (TempFile tempFile = TempFile.create("pants_export_run", ".out")) {
commandline.addParameter(
String.format("%s=%s", PantsConstants.PANTS_CLI_OPTION_EXPORT_OUTPUT_FILE,
Expand Down
2 changes: 1 addition & 1 deletion scripts/prepare-ci-environment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ fi

# we will use Community ids to download plugins.
export SCALA_PLUGIN_ID="org.intellij.scala"
export SCALA_PLUGIN_MD5="e2b247e6c5edf2a6d7e2472769ec2bb7" # 2017.2.11
export SCALA_PLUGIN_MD5="474ec053a0fbf6a9772b380c1efaf03e" # 2017.2.13

export INTELLIJ_PLUGINS_HOME="$CWD/.cache/intellij/$FULL_IJ_BUILD_NUMBER/plugins"
export INTELLIJ_HOME="$CWD/.cache/intellij/$FULL_IJ_BUILD_NUMBER/idea-dist"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ private ProcessOutput getProcessOutput(
private GeneralCommandLine getCommand(final File outputFile, @NotNull Consumer<String> statusConsumer)
throws IOException, ExecutionException {
final GeneralCommandLine commandLine = PantsUtil.defaultCommandLine(getProjectPath());
commandLine.addParameter("--no-quiet");
commandLine.addParameter("export");
commandLine.addParameter("--formatted"); // json outputs in a compact format
if (myResolveSourcesAndDocsForJars) {
Expand Down

0 comments on commit f4f2f99

Please sign in to comment.