Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-7135]: Updates code to resolve auth issue. #359

Merged
merged 14 commits into from
Nov 22, 2023
Merged

Conversation

rwagner00
Copy link
Contributor

@rwagner00 rwagner00 commented Nov 21, 2023

This PR updates the auth issue that was reported. It also updates the Behat tests so that they're passing using the latest pantheon-wordpress-upstream-tests (which involved updating the child theme created in the behat-prepare script). I've also added more verbose logging during behat-prepare so we have a better idea of what's going on since this behat-prepare differs from most of our other repositories.

@rwagner00 rwagner00 requested a review from a team as a code owner November 21, 2023 20:56
this is always going to point to the parent theme, so it's better for the stylesheet name to be something generic rather than something outdated
because this prepare script differs from most of our other behat-prepare scripts, let's be more explicit about the steps so we know what it's doing when we look back at this in six+ months
@jazzsequence jazzsequence changed the base branch from master to develop November 22, 2023 21:19
@jazzsequence jazzsequence merged commit 5ca7ac4 into develop Nov 22, 2023
8 checks passed
@jazzsequence jazzsequence deleted the BUGS-7135-Auth branch November 22, 2023 21:37
@jazzsequence jazzsequence mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants