Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync clean-up of development branch #344

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Re-sync clean-up of development branch #344

merged 5 commits into from
Jun 21, 2023

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Jun 13, 2023

To get out of the mess of squash merges and merge conflicts on these branches, I backed up and deleted the develop branch and force-pushed master's history back to develop.

Develop pre-cleanup is backed up to https://github.com/pantheon-systems/wp-saml-auth/tree/develop-stash.
commits have been cherry-picked over to this PR branch, and I manually re-applied #342.

Also re-applies #339 #341 #343.

Following this, we should be in better shape to work through development and releases as described in CONTRIBUTING.MD and modeled in https://github.com/pantheon-systems/plugin-pipeline-example.

This PR should rebased, not squashed or merged.

jazzsequence and others added 5 commits June 13, 2023 11:34
* add our coding standard

* run phpcbf

* updates the ruleset name to be less generic

* add rule exclusions in specific files

* bump the php test version

* remove excluded squiz rule
we're handling that inside Pantheon-WP

* manual rule exclusions

* use wp_kses to sanitize output

* validate & sanitize PHP superclobal

* set lint php version to 8.0
Bumps [symfony/filesystem](https://github.com/symfony/filesystem) from 5.4.21 to 5.4.23.
- [Release notes](https://github.com/symfony/filesystem/releases)
- [Changelog](https://github.com/symfony/filesystem/blob/6.2/CHANGELOG.md)
- [Commits](symfony/filesystem@v5.4.21...v5.4.23)

---
updated-dependencies:
- dependency-name: symfony/filesystem
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump yoast/phpunit-polyfills from 1.0.5 to 2.0.0

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.5 to 2.0.0.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.5...2.0.0)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
jazzsequence previously approved these changes Jun 21, 2023
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pwtyler pwtyler changed the base branch from master to develop June 21, 2023 18:47
@pwtyler pwtyler dismissed jazzsequence’s stale review June 21, 2023 18:47

The base branch was changed.

@pwtyler pwtyler requested a review from jazzsequence June 21, 2023 18:47
@pwtyler pwtyler merged commit 9e7c0ee into develop Jun 21, 2023
@pwtyler pwtyler deleted the develop-stash-two branch June 21, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants