Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMS-1033] Add actions for building tags and deploying to wp.org #309

Merged
merged 11 commits into from
Nov 21, 2022
Merged

[CMS-1033] Add actions for building tags and deploying to wp.org #309

merged 11 commits into from
Nov 21, 2022

Conversation

jspellman814
Copy link
Contributor

No description provided.

@jspellman814 jspellman814 requested a review from a team as a code owner November 16, 2022 22:25
CdrMarks
CdrMarks suggested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@CdrMarks CdrMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the SVN secrets be added to the repo first?

CdrMarks
CdrMarks reviewed Nov 16, 2022
View reviewed changes
readme.txt Outdated Show resolved Hide resolved
@jspellman814
Copy link
Contributor Author

The secrets are here: https://github.com/pantheon-systems/wp-saml-auth/settings/secrets/actions

@CdrMarks CdrMarks self-requested a review November 16, 2022 22:44
CdrMarks
CdrMarks previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@CdrMarks CdrMarks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the release date is updated.

@jspellman814 jspellman814 changed the base branch from master to develop November 21, 2022 17:53
@jspellman814 jspellman814 requested review from CdrMarks and a team November 21, 2022 18:11
@CdrMarks
Copy link
Contributor

@jspellman814 I see the Changelog was removed. Can you explain or link to how the new workflow works?

@jazzsequence
Copy link
Contributor

@CdrMarks

I see the Changelog was removed. Can you explain or link to how the new workflow works?

Where are you seeing that?

https://github.com/pantheon-systems/wp-saml-auth/pull/309/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R276

https://github.com/pantheon-systems/wp-saml-auth/pull/309/files#diff-9e6e4772050998a5c0dc3c61acf3dab0a7e594566171fa5746d6b62f9598efb6R274

@CdrMarks
Copy link
Contributor

Where are you seeing that?

In this commit: f39463c

@jazzsequence
Copy link
Contributor

@CdrMarks

  1. Starting from develop, cut a release branch named release_X.Y.Z containing your changes.
  2. Update plugin version in package.json, README.md, readme.txt, and wp-saml-auth.php.
  3. Update the Changelog with the latest changes.
  4. Create a PR against the master branch.
  5. After all tests pass and you have received approval from a CODEOWNER (including resolving any merge conflicts), merge the PR into master.
  6. Check the Build and Tag action: a new tag named with the version number should've been created. It should contain all the built assets.
  7. Create a new release, naming the release with the new version number, and targeting the tag created in the previous step. Paste the release changelog from CHANGELOG.md into the body of the release and include a link to the closed issues if applicable.
  8. Wait for the Release wp-saml-auth plugin to wp.org action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
  9. Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/solr-power/. This may take a few minutes.

Because this isn't the release PR, the changelog should not be updated yet

jazzsequence
jazzsequence previously approved these changes Nov 21, 2022
View reviewed changes
@jspellman814 jspellman814 merged commit 4c3601a into develop Nov 21, 2022
@jspellman814 jspellman814 deleted the cms-1033 branch November 21, 2022 21:03
jspellman814 pushed a commit that referenced this pull request Mar 10, 2023
[CMS-1033] Add actions for building tags and deploying to wp.org (#309)
6bd78b1
jazzsequence added a commit that referenced this pull request Apr 7, 2023
@jazzsequence @dependabot
Release 2.1.2 (#335)
4ec38cb 
* [CMS-1033] Add actions for building tags and deploying to wp.org (#309)

* [CMS-1033] Fix GH action (#311)

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4 (#310)

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/develop/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.3...1.0.4)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Spellman <[email protected]>

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4 (#308)

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/develop/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.3...1.0.4)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Spellman <[email protected]>

* Make dependabot target develop branch (#313)

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4 (#314)

* [CMS-1033] Release 2.1.0 (#312)

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/develop/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.3...1.0.4)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Spellman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 (#321)

* Bump symfony/filesystem from 5.4.9 to 5.4.19 (#322)

* Bump grunt from 1.5.3 to 1.6.1 (#323)

* Bump grunt from 1.5.3 to 1.6.1 (#326)

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 (#325)

* Bump symfony/filesystem from 5.4.9 to 5.4.19 (#324)

* Bump symfony/filesystem from 5.4.9 to 5.4.21 (#330)

Bumps [symfony/filesystem](https://github.com/symfony/filesystem) from 5.4.9 to 5.4.21.
- [Release notes](https://github.com/symfony/filesystem/releases)
- [Changelog](https://github.com/symfony/filesystem/blob/6.2/CHANGELOG.md)
- [Commits](symfony/filesystem@v5.4.9...v5.4.21)

---
updated-dependencies:
- dependency-name: symfony/filesystem
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Reynolds <[email protected]>

* Test more versions of PHP

* Bump yoast/phpunit-polyfills from 1.0.4 to 1.0.5 (#334)

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.4...1.0.5)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bump versions and tested up to versions

* add john & chris as contributors

* move circle build badge and remove travis badge

* updae changelog

* run composer update before install

* update to today's date

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Spellman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CdrMarks CdrMarks CdrMarks approved these changes

@jazzsequence jazzsequence jazzsequence left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jspellman814 @CdrMarks @jazzsequence