Only add SAML button and explanations on login action #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've noticed the extra HTML the plugin injects into the
wp-login.phppage to explain how to login with SAML or with WordPress is output no matter what the login action. For instance, when you want to get the link to reset your password, here's how thewp-login.phppage looks:I believe it's a bit confusing, because if I arrive there, it's because i want to connect with WordPress but I lost my password. So the extra HTML shouldn't be output. I haven't tested other login actions but I believe the same extra HTML would be output.
This PR suggests to check if the
login_form_loginaction happened before injecting this extra HTML.