Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic settings page for OneLogin (continued) #151

Merged
merged 37 commits into from
May 14, 2019
Merged

Add basic settings page for OneLogin (continued) #151

merged 37 commits into from
May 14, 2019

Conversation

danielbachhuber
Copy link
Contributor

Continuation of #143
Fixes #80

@danielbachhuber danielbachhuber mentioned this pull request May 14, 2019
Closed
@danielbachhuber
Avoid options static cache
5a905b2
@danielbachhuber
Use the $settings if they exist, otherwise fall back to $value
efc9904
@danielbachhuber
Rename settings to 'WP SAML Auth'; make it localizable
96ffd61
@danielbachhuber
Add escaping around fields
b427478
@danielbachhuber
Remove unused code
ec74429
@danielbachhuber
Allow strings to be localized
fc14931
@danielbachhuber
Use menu_page_url() here
506b604
@danielbachhuber
Another string to localize
ee09b7b
@danielbachhuber
Use a static method that can be called from either class
750b78d
@danielbachhuber
Run at an earlier priority so user filter always overrides
832c506
@danielbachhuber
Remove 'connection_type' option because 'internal' is the only supported
8866ecd
@danielbachhuber
Update a few more instances of option name references
623a598
@danielbachhuber
Hide the options page if there's a filter applied
35b433b
@danielbachhuber
Needs to run early because WP SAML Auth initializes on init
52acbff
@danielbachhuber
'connection_type' is no longer set, so use 'baseurl' as reference
a29158b
@danielbachhuber
Use direct $instance reference
f4ad177
@danielbachhuber
Allow all of these options to be set too
1a8bc9f
@danielbachhuber danielbachhuber added this to the 0.5.3 milestone May 14, 2019
@danielbachhuber
Copy link
Contributor Author

@scottmckenzie Worth taking a look through the additional changes I made ^

@danielbachhuber danielbachhuber merged commit bc8274f into master May 14, 2019
@danielbachhuber danielbachhuber deleted the 80-options-page branch May 14, 2019 16:53
@danielbachhuber danielbachhuber mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Provide UI to update and amend settings via plugin
2 participants
@danielbachhuber @akscottmckenzie