Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE-2632] Fix Relay support in check_client_dependencies #473

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Dec 6, 2024

Alternative version of #471 with bool adjustment, green tests, and changelog update.

@pwtyler pwtyler force-pushed the patch-6 branch 2 times, most recently from 441b528 to 2d838be Compare December 6, 2024 21:48
@pwtyler pwtyler changed the title Alternative relay check [SITE-2632] Alternative relay check Dec 6, 2024
EarthlingDavey and others added 3 commits December 6, 2024 14:02
This PR fixes 2 cases where `WP_REDIS_USE_RELAY=true`

- The class is not checked for existence.
- The drop-in will not run if Redis extension is not installed.

The fix:

- Relay\Relay is correctly checked for existence.
- The drop-in still works if the Redis extension is not installed.
Co-authored-by: Chris Reynolds <[email protected]>
@pwtyler pwtyler marked this pull request as ready for review December 6, 2024 22:02
@pwtyler pwtyler requested a review from a team as a code owner December 6, 2024 22:02
@pwtyler
Copy link
Member Author

pwtyler commented Dec 6, 2024

@EarthlingDavey, do you have a WordPress.org profile you'd like us to include in readme.txt changelog?

@EarthlingDavey
Copy link
Contributor

Hey @pwtyler thanks for the mention in the readme ... I don't have a .org profile.

@pwtyler pwtyler merged commit c4e5971 into main Dec 9, 2024
17 checks passed
@pwtyler pwtyler deleted the patch-6 branch December 9, 2024 23:03
@pwtyler pwtyler changed the title [SITE-2632] Alternative relay check [SITE-2632] Fix Relay support in check_client_dependencies Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants