Allow timeout to be set via CACHE_TIMEOUT env var.
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwtyler
reviewed
Dec 18, 2024
| @@ -1258,6 +1261,7 @@ public function build_client_parameters( $redis_server ) { | |||
| // @phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized | |||
| 'auth' => ! empty( $_SERVER['CACHE_PASSWORD'] ) ? $_SERVER['CACHE_PASSWORD'] : null, | |||
| 'database' => ! empty( $_SERVER['CACHE_DB'] ) ? intval( $_SERVER['CACHE_DB'] ) : $database, | |||
| 'timeout' => isset( $_SERVER['CACHE_TIMEOUT'] ) ? intval( $_SERVER['CACHE_TIMEOUT'] ) : $timeout, | |||
There was a problem hiding this comment.
This check's current position in the Pantheon config conditional is a problem, as it only would get used if config set by the Pantheon env exists (CACHE_HOST et.al). Since this is not a config value Pantheon envs set, better to move it outside of the current block (probably up at 1250?) making this more portable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.