[CMSP-676] WP Redis PHP 8.3 compatibility checks #446
Conversation
still need to enable redis
jazzsequence
changed the title
so they're easier to see and because I'm a dork
and export the WP_REDIS_USE_CACHE_GROUPS var for redis tests
| if [ ${{ matrix.redis_enabled }} = 'true' ]; then | ||
| export WP_REDIS_USE_CACHE_GROUPS=1 |
There was a problem hiding this comment.
if you made ${{ matrix.redis_enabled }} 1 and 0, you could just export the env variable and lose the conditional but then you don't have the emoji 😁
There was a problem hiding this comment.
keeping the damn emoji. 😀
| "shasum": "" | ||
| }, | ||
| "require": { | ||
| "php": "^7.1 || ^8.0" | ||
| "php": "^8.1" |
There was a problem hiding this comment.
could this cause us to unintentionally drop 7.4 compat?
There was a problem hiding this comment.
I don't think so.
There aren't any required libraries that are consumed by users. So there's nothing that Composer knows about that users on 7.4 would care about. For our 7.4 testing, we composer update specifically because some of the dependencies are different between 7.x and 8.x (for the 8.x builds we don't need to composer update, we can just composer install). I think this must've gotten auto-changed due to some dependency package requiring a higher version of PHP.
pantheon-systems/wpunit-helpersinstall-wp-tests.shfrom version control (installed viawpunit-helpers)object-cache.php