Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING docs #439

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Update CONTRIBUTING docs #439

merged 2 commits into from
Jun 26, 2023

Conversation

jazzsequence
Copy link
Contributor

Replaces default with main and adds note to create a merge commit for the release PR rather than rebase.

@jazzsequence
replace default with main
07cfdf9
@jazzsequence
update "rebase and merge" with merge commit
584b425 
this is still experimental but this way we don't bork our future selves by doing the wrong thing
@jazzsequence jazzsequence requested review from a team as code owners June 26, 2023 18:55
pwtyler
pwtyler approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these days we'll get this process down.

@jazzsequence jazzsequence merged commit 4e8c04e into main Jun 26, 2023
@jazzsequence jazzsequence deleted the update-contributing-docs branch June 26, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwtyler pwtyler pwtyler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jazzsequence @pwtyler