Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move common phpunit steps to commands to shorten up circle config #419

Merged
merged 1 commit into from
May 12, 2023

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented May 12, 2023

Working on #415, I ended up cleaning up the circle config file quite a bit, but while the new CLI bash script is not quite ready, I'd like to get the phpunit test cleanup in place.

Incidentally, maintaining these dependencies in a separate image re-used would mean ~1 minute off each test.

@pwtyler pwtyler marked this pull request as ready for review May 12, 2023 19:39
@pwtyler pwtyler requested review from a team as code owners May 12, 2023 19:39
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pwtyler pwtyler merged commit 60b908a into default May 12, 2023
@pwtyler pwtyler deleted the DRY-phpunit branch May 12, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants