Add cms-platform to CODEOWNERS file #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspellman814
approved these changes
Apr 6, 2023
|
I'm -1 on this change as it creates duplicate notifications for those of us in both teams. |
|
@CdrMarks As CMS Platform is the team that maintains this, it feels odd that we don't "own" this plugin (and all others). GitHub streaming notifications into Slack are already a firehose and I don't think it's worth restricting our ownership to better benefit that specific integration. Whether we want to remove CMS Operations in favor of using CMS Platform as the owner is a different question. |
jazzsequence
added a commit
that referenced
this pull request
Apr 6, 2023
* [CMS-1033] Add GH action for deployments to wp.org (#368) * Make dependabot target develop branch (#376) * Declare wp_cache_supports function and support features (#378) * Fix broken wp_cache_supports() (#382) * Update images for lint and test-behat jobs * Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4 * Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0. - [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases) - [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator) - [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0) --- updated-dependencies: - dependency-name: dealerdirect/phpcodesniffer-composer-installer dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump grunt from 1.5.2 to 1.6.1 (#386) * [CMSP-223] WP Redis housekeeping (#387) * [CMS-1033] Release 1.3.0 (#371) * [BUGS-5583] Release 1.3.1 (#379) * Release 1.3.2 (#383) * add spdy-compatible license version * remove reference to package.json --------- Co-authored-by: John Spellman <[email protected]> * [CMSP-72] PHP 8.2 compatibility (#388) * [BUGS-5623] Set missing_redis_message if Redis service is not connected (#391) * Set missing_redis_message if Redis is not connected * i18n * Bump yoast/phpunit-polyfills from 1.0.4 to 1.0.5 (#394) Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases) - [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md) - [Commits](Yoast/PHPUnit-Polyfills@1.0.4...1.0.5) --- updated-dependencies: - dependency-name: yoast/phpunit-polyfills dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * version bump * update changelogs * add chris and john to contributors * Add cms-platform to CODEOWNERS file (#396) * update date --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: John Spellman <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.