[BUGS-6317] Adds $admin property #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR intends to fix this error added by PHP 8.2: Deprecated: Creation of dynamic property Pantheon_Sessions::$admin is deprecated in /usr/src/app/content/plugins/wp-native-php-sessions/pantheon-sessions.php on line 93
pwtyler
approved these changes
May 30, 2023
pwtyler
requested changes
May 30, 2023
There was a problem hiding this comment.
Rescinding approval, @jazzsequence, can you update the changelog before merging?
|
@pwtyler all ready for release |
jazzsequence
force-pushed
the
deprecated-dynamic-property-error
branch
from
107f629 to
75a1d8e
Compare
pwtyler
approved these changes
Jun 1, 2023
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Adds $admin property This PR intends to fix this error added by PHP 8.2: Deprecated: Creation of dynamic property Pantheon_Sessions::$admin is deprecated in /usr/src/app/content/plugins/wp-native-php-sessions/pantheon-sessions.php on line 93 * fixes lints that were missed in previous PR * bump version * bump version, tested up to & update changelog * re-add plucked stable tag
Merged
pwtyler
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Adds $admin property This PR intends to fix this error added by PHP 8.2: Deprecated: Creation of dynamic property Pantheon_Sessions::$admin is deprecated in /usr/src/app/content/plugins/wp-native-php-sessions/pantheon-sessions.php on line 93 * fixes lints that were missed in previous PR * bump version * bump version, tested up to & update changelog * re-add plucked stable tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix this error added by PHP 8.2:
Deprecated: Creation of dynamic property Pantheon_Sessions::$admin is deprecated in /usr/src/app/content/plugins/wp-native-php-sessions/pantheon-sessions.php on line 93
Copied from #250 by @MiguelAxcar